usb: hso: fix error handling code of hso_create_net_device
authorDongliang Mu <mudongliangabcd@gmail.com>
Wed, 21 Jul 2021 08:14:56 +0000 (16:14 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 21 Jul 2021 15:59:56 +0000 (08:59 -0700)
commit788e67f18d797abbd48a96143511261f4f3b4f21
treedb373d221e858c287ba63fe8d203e7053ea33962
parent1050713026a08d605b61f039700b67aab646371f
usb: hso: fix error handling code of hso_create_net_device

The current error handling code of hso_create_net_device is
hso_free_net_device, no matter which errors lead to. For example,
WARNING in hso_free_net_device [1].

Fix this by refactoring the error handling code of
hso_create_net_device by handling different errors by different code.

[1] https://syzkaller.appspot.com/bug?id=66eff8d49af1b28370ad342787413e35bbe76efe

Reported-by: syzbot+44d53c7255bb1aea22d2@syzkaller.appspotmail.com
Fixes: 5fcfb6d0bfcd ("hso: fix bailout in error case of probe")
Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/hso.c