of/platform: increase refcount of fwnode
authorPeng Fan <peng.fan@nxp.com>
Mon, 21 Aug 2023 02:39:28 +0000 (10:39 +0800)
committerRob Herring <robh@kernel.org>
Mon, 21 Aug 2023 21:12:28 +0000 (16:12 -0500)
commit7882541ca06d51a6c12d687827176c16d5e05f65
tree417c4ed9c1cc3e3440fc803510a4d72a0bfeb3dc
parent914d9d831e6126a6e7a92e27fcfaa250671be42c
of/platform: increase refcount of fwnode

commit 0f8e5651095b
("of/platform: Propagate firmware node by calling device_set_node()")
use of_fwnode_handle to replace of_node_get, which introduces a side
effect that the refcount is not increased. Then the out of tree
jailhouse hypervisor enable/disable test will trigger kernel dump in
of_overlay_remove, with the following sequence
"
   of_changeset_revert(&overlay_changeset);
   of_changeset_destroy(&overlay_changeset);
   of_overlay_remove(&overlay_id);
"

So increase the refcount to avoid issues.

This patch also release the refcount when releasing amba device to avoid
refcount leakage.

Fixes: 0f8e5651095b ("of/platform: Propagate firmware node by calling device_set_node()")
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
Link: https://lore.kernel.org/r/20230821023928.3324283-2-peng.fan@oss.nxp.com
Signed-off-by: Rob Herring <robh@kernel.org>
drivers/of/platform.c