drm/i915: Always enable CGM CSC on CHV
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Thu, 13 Apr 2023 16:49:13 +0000 (19:49 +0300)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 26 May 2023 15:02:49 +0000 (18:02 +0300)
commit78776086371bf8aba4314a52a46c52d946984c61
treeeee20ecae74f898a334679f8e615761d5e5feb1e
parent2587c63aaaf47f6f4ea9d90047910534a3ecf432
drm/i915: Always enable CGM CSC on CHV

On CHV toggling the CGM CSC on/off while the pipe is running leads
to underruns. Looks like we'd have to do the toggling strictly inside
the start_of_vblank-frame_start window to avoid this, but that window
is less than a scanline so there's no way we can guarantee hitting it.

As a workaround let's just leave the CGM CSC permanently enabled.
Fortunately the CGM gamma/degamma units don't seem to suffer from
this malady.

I also tried turning off CGM unit clock gating, but that did not
help.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230413164916.4221-5-ville.syrjala@linux.intel.com
Reviewed-by: Uma Shankar <uma.shankar@intel.com>
drivers/gpu/drm/i915/display/intel_color.c