media: s5p-mfc: Fix a reference count leak
authorQiushi Wu <wu000273@umn.edu>
Sun, 14 Jun 2020 02:31:22 +0000 (04:31 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Sun, 27 Sep 2020 08:53:29 +0000 (10:53 +0200)
commit78741ce98c2e36188e2343434406b0e0bc50b0e7
tree021fb18029accc463b7a0823da105d0a92170257
parentd0675b67b42eb4f1a840d1513b5b00f78312f833
media: s5p-mfc: Fix a reference count leak

pm_runtime_get_sync() increments the runtime PM usage counter even
when it returns an error code, causing incorrect ref count if
pm_runtime_put_noidle() is not called in error handling paths.
Thus call pm_runtime_put_noidle() if pm_runtime_get_sync() fails.

Fixes: c5086f130a77 ("[media] s5p-mfc: Use clock gating only on MFC v5 hardware")
Signed-off-by: Qiushi Wu <wu000273@umn.edu>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/s5p-mfc/s5p_mfc_pm.c