bonding: remove locking from bond_set_rx_mode()
authorVeaceslav Falico <vfalico@redhat.com>
Mon, 5 Aug 2013 12:56:06 +0000 (14:56 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 5 Aug 2013 19:22:53 +0000 (12:22 -0700)
commit7864a1adf7291993d74923fdd0a45459ce9da27e
tree58513abad3228c4ebfe6b04a15b2a1d333846607
parentc193f3655d9b916a3b8cb685c6b4327397507b2f
bonding: remove locking from bond_set_rx_mode()

We're already protected by RTNL lock, so nothing can happen to bond/its
slaves, and thus the locking is useless here (both bond->lock and
bond->curr_active_slave).

Also, add ASSERT_RTNL() both to bond_set_rx_mode() and bond_hw_addr_swap()
to catch possible uses of it without RTNL locking.

This patch also saves us from a lockdep false-positive in
bond_set_rx_mode() vs bond_hw_addr_swap().

CC: Jay Vosburgh <fubar@us.ibm.com>
CC: Andy Gospodarek <andy@greyhouse.net>
CC: Nikolay Aleksandrov <nikolay@redhat.com>
Signed-off-by: Veaceslav Falico <vfalico@redhat.com>
Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/bonding/bond_main.c