Remove unused locals and fix tests in System.ServiceModel.Syndication (#39639)
authorMatt Kotsenas <mattkot@microsoft.com>
Wed, 16 Sep 2020 23:41:45 +0000 (16:41 -0700)
committerGitHub <noreply@github.com>
Wed, 16 Sep 2020 23:41:45 +0000 (16:41 -0700)
commit783913897623ed0af0d5e750b0657d923fac9a2c
tree77f6a5d2aa833afb0cc6d8fb047b49afe00b8724
parent9aea1a7d11ccfa08eff7c68f9ecff8b857c0a3a8
Remove unused locals and fix tests in System.ServiceModel.Syndication (#39639)

* Remove unused locals and fix tests in System.ServiceModel.Syndication

Remove unused locals in System.ServiceModel.Syndication.

While refactoring I found two places where unit tests appear to have a
copy/paste error and were asserting the wrong value.

* Add back `thirdDocument` and correct tests

* Add back `sixthDocument` and correct tests

* Add back item and correct tests

* Add back `genericFormatter` and correct test

* Add back `elementExtensions` and add assert
src/libraries/System.ServiceModel.Syndication/tests/System/ServiceModel/Syndication/AtomPub10CategoriesDocumentFormatterTests.cs
src/libraries/System.ServiceModel.Syndication/tests/System/ServiceModel/Syndication/AtomPub10ServiceDocumentFormatterTests.cs
src/libraries/System.ServiceModel.Syndication/tests/System/ServiceModel/Syndication/Rss20FeedFormatterTests.cs
src/libraries/System.ServiceModel.Syndication/tests/System/ServiceModel/Syndication/Rss20ItemFormatterTests.cs
src/libraries/System.ServiceModel.Syndication/tests/System/ServiceModel/Syndication/SyndicationElementExtensionCollectionTests.cs
src/libraries/System.ServiceModel.Syndication/tests/System/ServiceModel/Syndication/SyndicationElementExtensionTests.cs
src/libraries/System.ServiceModel.Syndication/tests/System/ServiceModel/Syndication/SyndicationFeedTests.cs
src/libraries/System.ServiceModel.Syndication/tests/System/ServiceModel/Syndication/SyndicationFeedTests.netcoreapp.cs
src/libraries/System.ServiceModel.Syndication/tests/Utils/XmlDiffDocument.cs