nfs3_list_one_acl(): check get_acl() result with IS_ERR_OR_NULL
authorAndrey Utkin <andrey.krieger.utkin@gmail.com>
Sat, 26 Jul 2014 11:58:01 +0000 (14:58 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 5 Sep 2014 23:34:18 +0000 (16:34 -0700)
commit78359f18aa15699d96b613c8cb7b43471c7157da
tree2e79d2dda6f8a883ab0aef03dc4d3d672b7b9e7f
parentd29135ddc8f0c3084693d6770c412f3b3b94a1c0
nfs3_list_one_acl(): check get_acl() result with IS_ERR_OR_NULL

commit 7a9e75a185e6b3a3860e6a26fb6e88691fc2c9d9 upstream.

There was a check for result being not NULL. But get_acl() may return
NULL, or ERR_PTR, or actual pointer.
The purpose of the function where current change is done is to "list
ACLs only when they are available", so any error condition of get_acl()
mustn't be elevated, and returning 0 there is still valid.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=81111
Signed-off-by: Andrey Utkin <andrey.krieger.utkin@gmail.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Fixes: 74adf83f5d77 (nfs: only show Posix ACLs in listxattr if actually...)
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/nfs/nfs3acl.c