Reapply "Try enabling -Wsuggest-override again, using add_compile_options instead...
authorLogan Smith <logan.r.smith0@gmail.com>
Thu, 23 Jul 2020 00:44:52 +0000 (17:44 -0700)
committerLogan Smith <logan.r.smith0@gmail.com>
Thu, 23 Jul 2020 00:50:19 +0000 (17:50 -0700)
commit77e0e9e17daf0865620abcd41f692ab0642367c4
tree0756b0942faa742de5492ed4412962b353d88f6f
parentebe5f17f9c396f14742a7c747951b65eaada158e
Reapply "Try enabling -Wsuggest-override again, using add_compile_options instead of add_compile_definitions for disabling it in unittests/ directories."

add_compile_options is more sensitive to its location in the file than add_definitions--it only takes effect for sources that are added after it. This updated patch ensures that the add_compile_options is done before adding any source files that depend on it.

Using add_definitions caused the flag to be passed to rc.exe on Windows and thus broke Windows builds.
18 files changed:
clang-tools-extra/clangd/unittests/CMakeLists.txt
clang-tools-extra/unittests/CMakeLists.txt
clang/unittests/CMakeLists.txt
compiler-rt/cmake/Modules/AddCompilerRT.cmake
compiler-rt/cmake/config-ix.cmake
flang/unittests/CMakeLists.txt
libcxx/CMakeLists.txt
libcxxabi/CMakeLists.txt
lld/unittests/CMakeLists.txt
lldb/unittests/CMakeLists.txt
llvm/cmake/modules/HandleLLVMOptions.cmake
llvm/lib/Testing/Support/CMakeLists.txt
llvm/unittests/CMakeLists.txt
llvm/utils/benchmark/CMakeLists.txt
llvm/utils/unittest/CMakeLists.txt
mlir/unittests/CMakeLists.txt
parallel-libs/acxxel/CMakeLists.txt
polly/unittests/CMakeLists.txt