irda: Fix memory leak caused by repeated binds of irda socket
authorTyler Hicks <tyhicks@canonical.com>
Tue, 4 Sep 2018 15:24:04 +0000 (15:24 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 15 Sep 2018 07:45:36 +0000 (09:45 +0200)
commit77be9452d0e5768bab9a041a62116cbeb9dc3174
treea92d6ab324c8575ecbeb4e5d49d1843dafdd94dd
parent63fd9d43c0181d668e632832e66c123faf66cfd3
irda: Fix memory leak caused by repeated binds of irda socket

The irda_bind() function allocates memory for self->ias_obj without
checking to see if the socket is already bound. A userspace process
could repeatedly bind the socket, have each new object added into the
LM-IAS database, and lose the reference to the old object assigned to
the socket to exhaust memory resources. This patch errors out of the
bind operation when self->ias_obj is already assigned.

CVE-2018-6554

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Tyler Hicks <tyhicks@canonical.com>
Reviewed-by: Seth Arnold <seth.arnold@canonical.com>
Reviewed-by: Stefan Bader <stefan.bader@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/irda/net/af_irda.c