jump_label: Fix NULL dereference bug in __jump_label_mod_update()
authorArd Biesheuvel <ard.biesheuvel@linaro.org>
Mon, 1 Oct 2018 08:13:24 +0000 (10:13 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Tue, 2 Oct 2018 06:08:18 +0000 (08:08 +0200)
commit77ac1c02d9f20a0d72fa992c88b98c15d087dbca
tree6e3ad7ecc4756b0b8ccc6de075fb8bc855a76c6a
parent57d15877033e44e9ac283b8c6e82cc67bf6a0aa6
jump_label: Fix NULL dereference bug in __jump_label_mod_update()

Commit 19483677684b ("jump_label: Annotate entries that operate on
__init code earlier") refactored the code that manages runtime
patching of jump labels in modules that are tied to static keys
defined in other modules or in the core kernel.

In the latter case, we may iterate over the static_key_mod linked
list until we hit the entry for the core kernel, whose 'mod' field
will be NULL, and attempt to dereference it to get at its 'state'
member.

So let's add a non-NULL check: this forces the 'init' argument of
__jump_label_update() to false for static keys that are defined in
the core kernel, which is appropriate given that __init annotated
jump_label entries in the core kernel should no longer be active
at this point (i.e., when loading modules).

Fixes: 19483677684b ("jump_label: Annotate entries that operate on ...")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Kees Cook <keescook@chromium.org>
Cc: Jessica Yu <jeyu@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20181001081324.11553-1-ard.biesheuvel@linaro.org
kernel/jump_label.c