ASoC: Intel: Skylake: Initialize lists before access so they are safe to use
authorAmadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Mon, 17 Jun 2019 11:36:34 +0000 (13:36 +0200)
committerMark Brown <broonie@kernel.org>
Tue, 25 Jun 2019 14:32:47 +0000 (15:32 +0100)
commit776cb3b80ede9ef4ad4c8aac22fcbdf4852b44cd
treed045225f50541b7ed9ede92d694f58c919d944d9
parentd5fcaaba54ce729a018e50938aa6d355cffc7ef4
ASoC: Intel: Skylake: Initialize lists before access so they are safe to use

If skl_probe_work() was not run driver ends up dereferencing NULL
pointer when operating on lists in skl_platform_unregister().
To fix this initialize lists in skl_create(). Also run
cancel_work_sync() before all cleanup functions, so we don't end up
unnecessarily running probe work.

Easily reproducible with:
while true; do modprobe snd_soc_skl; rmmod snd_soc_skl; done
(with the assumption that relevant drivers are added to blacklist on
system boot)

Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/skylake/skl-pcm.c
sound/soc/intel/skylake/skl.c