clocksource: Replace all non-returning strlcpy with strscpy
authorAzeem Shaikh <azeemshaikh38@gmail.com>
Tue, 30 May 2023 16:35:46 +0000 (16:35 +0000)
committerKees Cook <keescook@chromium.org>
Thu, 1 Jun 2023 18:24:50 +0000 (11:24 -0700)
commit76edc27eda068fb8222c452d522d4c93bcebe557
tree7a564577bb4dc77f00d74aa9a830148c5aa1914f
parentf9cfb1910ece5b5dbedca096fc9b7c9fe4fd3c50
clocksource: Replace all non-returning strlcpy with strscpy

strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Acked-by: John Stultz <jstultz@google.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230530163546.986188-1-azeemshaikh38@gmail.com
kernel/time/clocksource.c