Convert observers to C++
authorTom Tromey <tom@tromey.com>
Sun, 2 Oct 2016 16:50:20 +0000 (10:50 -0600)
committerTom Tromey <tom@tromey.com>
Mon, 19 Mar 2018 15:37:49 +0000 (09:37 -0600)
commit76727919ceb590f03ff0f6db08b7ceab5b7aeaff
treebf78b72a63f09f3d2c619048b15d73c5f343e806
parent194ed4130dadb7dd1668f6af87405bdcd8041199
Convert observers to C++

This converts observers from using a special source-generating script
to be plain C++.  This version of the patch takes advantage of C++11
by using std::function and variadic templates; incorporates Pedro's
patches; and renames the header file to "observable.h" (this change
eliminates the need for a clean rebuild).

Note that Pedro's patches used a template lambda in tui-hooks.c, but
this failed to compile on some buildbot instances (presumably due to
differing C++ versions); I replaced this with an ordinary template
function.

Regression tested on the buildbot.

gdb/ChangeLog
2018-03-19  Pedro Alves  <palves@redhat.com>
    Tom Tromey  <tom@tromey.com>

* unittests/observable-selftests.c: New file.
* common/observable.h: New file.
* observable.h: New file.
* ada-lang.c, ada-tasks.c, agent.c, aix-thread.c, annotate.c,
arm-tdep.c, auto-load.c, auxv.c, break-catch-syscall.c,
breakpoint.c, bsd-uthread.c, cli/cli-interp.c, cli/cli-setshow.c,
corefile.c, dummy-frame.c, event-loop.c, event-top.c, exec.c,
extension.c, frame.c, gdbarch.c, guile/scm-breakpoint.c,
infcall.c, infcmd.c, inferior.c, inflow.c, infrun.c, jit.c,
linux-tdep.c, linux-thread-db.c, m68klinux-tdep.c,
mi/mi-cmd-break.c, mi/mi-interp.c, mi/mi-main.c, objfiles.c,
ppc-linux-nat.c, ppc-linux-tdep.c, printcmd.c, procfs.c,
python/py-breakpoint.c, python/py-finishbreakpoint.c,
python/py-inferior.c, python/py-unwind.c, ravenscar-thread.c,
record-btrace.c, record-full.c, record.c, regcache.c, remote.c,
riscv-tdep.c, sol-thread.c, solib-aix.c, solib-spu.c, solib.c,
spu-multiarch.c, spu-tdep.c, stack.c, symfile-mem.c, symfile.c,
symtab.c, thread.c, top.c, tracepoint.c, tui/tui-hooks.c,
tui/tui-interp.c, valops.c: Update all users.
* tui/tui-hooks.c (tui_bp_created_observer)
(tui_bp_deleted_observer, tui_bp_modified_observer)
(tui_inferior_exit_observer, tui_before_prompt_observer)
(tui_normal_stop_observer, tui_register_changed_observer):
Remove.
(tui_observers_token): New global.
(attach_or_detach, tui_attach_detach_observers): New functions.
(tui_install_hooks, tui_remove_hooks): Use
tui_attach_detach_observers.
* record-btrace.c (record_btrace_thread_observer): Remove.
(record_btrace_thread_observer_token): New global.
* observer.sh: Remove.
* observer.c: Rename to observable.c.
* observable.c (namespace gdb_observers): Define new objects.
(observer_debug): Move into gdb_observers namespace.
(struct observer, struct observer_list, xalloc_observer_list_node)
(xfree_observer_list_node, generic_observer_attach)
(generic_observer_detach, generic_observer_notify): Remove.
(_initialize_observer): Update.
Don't include observer.inc.
* Makefile.in (generated_files): Remove observer.h, observer.inc.
(clean mostlyclean): Likewise.
(observer.h, observer.inc): Remove targets.
(SUBDIR_UNITTESTS_SRCS): Add observable-selftests.c.
(COMMON_SFILES): Use observable.c, not observer.c.
* .gitignore: Remove observer.h.

gdb/doc/ChangeLog
2018-03-19  Tom Tromey  <tom@tromey.com>

* observer.texi: Remove.

gdb/testsuite/ChangeLog
2018-03-19  Tom Tromey  <tom@tromey.com>

* gdb.gdb/observer.exp: Remove.
86 files changed:
gdb/.gitignore
gdb/ChangeLog
gdb/Makefile.in
gdb/ada-lang.c
gdb/ada-tasks.c
gdb/agent.c
gdb/aix-thread.c
gdb/annotate.c
gdb/arm-linux-nat.c
gdb/arm-tdep.c
gdb/auto-load.c
gdb/auxv.c
gdb/break-catch-syscall.c
gdb/breakpoint.c
gdb/bsd-uthread.c
gdb/cli/cli-interp.c
gdb/cli/cli-setshow.c
gdb/common/observable.h [new file with mode: 0644]
gdb/corefile.c
gdb/defs.h
gdb/doc/ChangeLog
gdb/doc/observer.texi [deleted file]
gdb/dummy-frame.c
gdb/event-loop.c
gdb/event-top.c
gdb/exec.c
gdb/extension.c
gdb/frame.c
gdb/gdbarch.c
gdb/guile/scm-breakpoint.c
gdb/inf-loop.c
gdb/infcall.c
gdb/infcmd.c
gdb/inferior.c
gdb/inflow.c
gdb/infrun.c
gdb/jit.c
gdb/linux-tdep.c
gdb/linux-thread-db.c
gdb/m68k-linux-tdep.c
gdb/mi/mi-cmd-break.c
gdb/mi/mi-interp.c
gdb/mi/mi-main.c
gdb/objfiles.c
gdb/observable.c [new file with mode: 0644]
gdb/observable.h [new file with mode: 0644]
gdb/observer.c [deleted file]
gdb/observer.sh [deleted file]
gdb/ppc-linux-nat.c
gdb/ppc-linux-tdep.c
gdb/printcmd.c
gdb/procfs.c
gdb/python/py-breakpoint.c
gdb/python/py-finishbreakpoint.c
gdb/python/py-inferior.c
gdb/python/py-unwind.c
gdb/ravenscar-thread.c
gdb/record-btrace.c
gdb/record-full.c
gdb/record.c
gdb/regcache.c
gdb/remote-notif.c
gdb/remote.c
gdb/riscv-tdep.c
gdb/rs6000-nat.c
gdb/sol-thread.c
gdb/solib-aix.c
gdb/solib-spu.c
gdb/solib-svr4.c
gdb/solib.c
gdb/spu-multiarch.c
gdb/spu-tdep.c
gdb/stack.c
gdb/symfile-debug.c
gdb/symfile-mem.c
gdb/symfile.c
gdb/symtab.c
gdb/testsuite/ChangeLog
gdb/testsuite/gdb.gdb/observer.exp [deleted file]
gdb/thread.c
gdb/top.c
gdb/tracepoint.c
gdb/tui/tui-hooks.c
gdb/tui/tui-interp.c
gdb/unittests/observable-selftests.c [new file with mode: 0644]
gdb/valops.c