dmaengine: qcom: bam_dma: Fix resource leak
authorJeffrey Hugo <jeffrey.l.hugo@gmail.com>
Thu, 17 Oct 2019 15:26:06 +0000 (08:26 -0700)
committerVinod Koul <vkoul@kernel.org>
Fri, 18 Oct 2019 07:57:58 +0000 (13:27 +0530)
commit7667819385457b4aeb5fac94f67f52ab52cc10d5
treeca96fd127e397b9a1f868b3dc71c1bf4fef915a6
parentec1ac309596a7bdf206743b092748205f6cd5720
dmaengine: qcom: bam_dma: Fix resource leak

bam_dma_terminate_all() will leak resources if any of the transactions are
committed to the hardware (present in the desc fifo), and not complete.
Since bam_dma_terminate_all() does not cause the hardware to be updated,
the hardware will still operate on any previously committed transactions.
This can cause memory corruption if the memory for the transaction has been
reassigned, and will cause a sync issue between the BAM and its client(s).

Fix this by properly updating the hardware in bam_dma_terminate_all().

Fixes: e7c0fe2a5c84 ("dmaengine: add Qualcomm BAM dma driver")
Signed-off-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20191017152606.34120-1-jeffrey.l.hugo@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/qcom/bam_dma.c