ipv6: fix a dst leak when removing its exception
authorXin Long <lucien.xin@gmail.com>
Tue, 13 Nov 2018 16:48:28 +0000 (00:48 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sat, 17 Nov 2018 03:44:15 +0000 (19:44 -0800)
commit761f60261b4401aa368d71d431b4c218af0efcee
tree3963e8f7e325e2c65d311bb70b520d6c823d7841
parent83e65df6dfece9eb588735459428f221eb930c0c
ipv6: fix a dst leak when removing its exception

These is no need to hold dst before calling rt6_remove_exception_rt().
The call to dst_hold_safe() in ip6_link_failure() was for ip6_del_rt(),
which has been removed in Commit 93531c674315 ("net/ipv6: separate
handling of FIB entries from dst based routes"). Otherwise, it will
cause a dst leak.

This patch is to simply remove the dst_hold_safe() call before calling
rt6_remove_exception_rt() and also do the same in ip6_del_cached_rt().
It's safe, because the removal of the exception that holds its dst's
refcnt is protected by rt6_exception_lock.

Fixes: 93531c674315 ("net/ipv6: separate handling of FIB entries from dst based routes")
Fixes: 23fb93a4d3f1 ("net/ipv6: Cleanup exception and cache route handling")
Reported-by: Li Shuang <shuali@redhat.com>
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Reviewed-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/route.c