[lldb][TerminalTest] Fix assertion failure
authorKazuki Sakamoto <sakamoto@splhack.org>
Fri, 16 Jun 2023 00:33:36 +0000 (17:33 -0700)
committerKazuki Sakamoto <kaz@meta.com>
Fri, 16 Jun 2023 04:24:40 +0000 (21:24 -0700)
commit75e93ec720739291640005681f062b0e1e8e0f53
tree927bad0a64444c91c4b06c5aa409684127e5a2d9
parent96ed1bda29effd169a3c6e5eb64efe34811f27e3
[lldb][TerminalTest] Fix assertion failure

D152712 replaced `llvm::sys::RetryAfterSignal(-1, ::open)` with
`FileSystem::Instance().Open` for bionic in PseudoTerminal::OpenSecondary, and
FileSystem::Instance() is failing with assertion on arm Linux.

The assertion should be FileSystem re-initialization check, therefore the
hypothesis is that TerminalTest tests are initializing FileSystem instance
repeatedly.

Use SubsystemRAII<FileSystem> to ensure tearing down the FileSystem instance.

Differential Revision: https://reviews.llvm.org/D153091
lldb/unittests/Host/posix/TerminalTest.cpp