perf hist: fix objdump output parsing
authorKonstantin Stepanyuk <kostyas@cqg.com>
Wed, 26 May 2010 22:10:11 +0000 (02:10 +0400)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 1 Jun 2010 08:44:36 +0000 (05:44 -0300)
commit75d9ef1707cf3db264a549142a1f54a5380d63dc
treeb23265c9b0ad7fb042e3f472ca5fed7b0a0205d3
parent546cf44a1b507c1cbb5cf42bbe6169780567f36f
perf hist: fix objdump output parsing

hist_entry__annotate() runs objdump with -S option so the output may contain
lines of any format. If a line starts with a colon strtoull() returns 0 and
calculated offset will be negative. This causes perf annotate segfaults.

Make sure that strtoull() has parsed at least one digit.

Cc: David S. Miller <davem@davemloft.net>
Cc: Frédéric Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Tom Zanussi <tzanussi@gmail.com>
LKML-Reference: <new-submission>
Signed-off-by: Konstantin Stepanyuk <konstantin.stepanyuk@gmail.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/hist.c