thinkpad-acpi: fix LED blinking through timer trigger
authorHenrique de Moraes Holschuh <hmh@hmh.eng.br>
Tue, 14 Apr 2009 02:44:11 +0000 (02:44 +0000)
committerLen Brown <len.brown@intel.com>
Sat, 18 Apr 2009 05:19:53 +0000 (01:19 -0400)
commit75bd3bf2ade9d548be0d2bde60b5ee0fdce0b127
tree0133d0631c052d4f3a9b9f3feee4dd905442b431
parent406e988bef742aa74cdc1f5fafc812ecebf7c02b
thinkpad-acpi: fix LED blinking through timer trigger

The set_blink hook code in the LED subdriver would never manage to get
a LED to blink, and instead it would just turn it on.  The consequence
of this is that the "timer" trigger would not cause the LED to blink
if given default parameters.

This problem exists since 2.6.26-rc1.

To fix it, switch the deferred LED work handling to use the
thinkpad-acpi-specific LED status (off/on/blink) directly.

This also makes the code easier to read, and to extend later.

Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: stable@kernel.org
Signed-off-by: Len Brown <len.brown@intel.com>
drivers/platform/x86/thinkpad_acpi.c