ext4: add missing brelse() in add_new_gdb_meta_bg()
authorLukas Czerner <lczerner@redhat.com>
Fri, 15 Mar 2019 04:15:32 +0000 (00:15 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 20 Apr 2019 07:07:46 +0000 (09:07 +0200)
commit75ac16ea2e0361af7c6da05cf813b95dd0ef773a
treee9265cdaab25c13410e23f211877e6b9a7bb15f7
parent8fb8f97679276a98b1bfe71e5889df7c1dc23e78
ext4: add missing brelse() in add_new_gdb_meta_bg()

[ Upstream commit d64264d6218e6892edd832dc3a5a5857c2856c53 ]

Currently in add_new_gdb_meta_bg() there is a missing brelse of gdb_bh
in case ext4_journal_get_write_access() fails.
Additionally kvfree() is missing in the same error path. Fix it by
moving the ext4_journal_get_write_access() before the ext4 sb update as
Ted suggested and release n_group_desc and gdb_bh in case it fails.

Fixes: 61a9c11e5e7a ("ext4: add missing brelse() add_new_gdb_meta_bg()'s error path")
Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/ext4/resize.c