media: staging: allegro: fix broken registration of controls
authorMichael Tretter <m.tretter@pengutronix.de>
Thu, 19 Mar 2020 09:16:30 +0000 (10:16 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Fri, 20 Mar 2020 08:05:25 +0000 (09:05 +0100)
commit75a0359f29435df5d44fce307a06aab73fa6ae08
treeaf24c4f0a89e99d88ecb6105f73a82aa0b6335f5
parent8082d0a33cbae16d268639586a38cf080777d791
media: staging: allegro: fix broken registration of controls

Since commit cc62c74749a3 ("media: allegro: add missed checks in
allegro_open()") the allegro device does provide v4l2 controls to user
space anymore. The reason is that v4l2_fh_init() initializes
fh->ctrl_handler to vdev->ctrl_handler, which invalidates the previous
driver override of the ctrl_handler.

Therefore, v4l2_fh_init() must be called before the driver overrides the
fh->ctrl_handler with its own handler.

Move the initialization of the fh back to the top, as the initialization
does not does not need to be reverted on errors, but it is enough to
free the channel.

Fixes: cc62c74749a3 ("media: allegro: add missed checks in allegro_open()")
Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/allegro-dvt/allegro-core.c