sched/rt: Fix rq's cpupri leak while enqueue/dequeue child RT entities
authorKirill Tkhai <tkhai@yandex.ru>
Wed, 27 Nov 2013 15:59:13 +0000 (19:59 +0400)
committerIngo Molnar <mingo@kernel.org>
Tue, 17 Dec 2013 14:08:44 +0000 (15:08 +0100)
commit757dfcaa41844595964f1220f1d33182dae49976
tree5fe7dd64a8e3d7355c28b55dba784555c0a3355b
parent5d4cf996cf134e8ddb4f906b8197feb9267c2b77
sched/rt: Fix rq's cpupri leak while enqueue/dequeue child RT entities

This patch touches the RT group scheduling case.

Functions inc_rt_prio_smp() and dec_rt_prio_smp() change (global) rq's
priority, while rt_rq passed to them may be not the top-level rt_rq.
This is wrong, because changing of priority on a child level does not
guarantee that the priority is the highest all over the rq. So, this
leak makes RT balancing unusable.

The short example: the task having the highest priority among all rq's
RT tasks (no one other task has the same priority) are waking on a
throttle rt_rq.  The rq's cpupri is set to the task's priority
equivalent, but real rq->rt.highest_prio.curr is less.

The patch below fixes the problem.

Signed-off-by: Kirill Tkhai <tkhai@yandex.ru>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
CC: Steven Rostedt <rostedt@goodmis.org>
CC: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/49231385567953@web4m.yandex.ru
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/sched/rt.c