nfc: fix memory leak in llcp_sock_connect()
authorXiaoming Ni <nixiaoming@huawei.com>
Thu, 25 Mar 2021 03:51:12 +0000 (11:51 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 26 Mar 2021 00:02:01 +0000 (17:02 -0700)
commit7574fcdbdcb335763b6b322f6928dc0fd5730451
treeb54ea3bdfb3be277f8680fd137a66f2be6b0f81d
parent8a4cd82d62b5ec7e5482333a72b58a4eea4979f0
nfc: fix memory leak in llcp_sock_connect()

In llcp_sock_connect(), use kmemdup to allocate memory for
 "llcp_sock->service_name". The memory is not released in the sock_unlink
label of the subsequent failure branch.
As a result, memory leakage occurs.

fix CVE-2020-25672

Fixes: d646960f7986 ("NFC: Initial LLCP support")
Reported-by: "kiyin(尹亮)" <kiyin@tencent.com>
Link: https://www.openwall.com/lists/oss-security/2020/11/01/1
Cc: <stable@vger.kernel.org> #v3.3
Signed-off-by: Xiaoming Ni <nixiaoming@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/nfc/llcp_sock.c