Change pe/coff build-id section name to '.buildid'
authorJon TURNEY <jon.turney@dronecode.org.uk>
Sat, 30 Aug 2014 14:02:49 +0000 (15:02 +0100)
committerJon TURNEY <jon.turney@dronecode.org.uk>
Mon, 8 Sep 2014 16:54:20 +0000 (17:54 +0100)
commit74fffc39827629fb48c9e24a7d12ebbd5693df4b
treea419369e64e5b4bf5e61bf6fd8fc6c7b12ff2ca2
parent2e4bb98a0e52acbb2da4ae441b89a568af26adf8
Change pe/coff build-id section name to '.buildid'

The section name used to store the build-id on pe/coff is arbitrary, as it's
contents should be located using the pe/coff header's DataDirectory debug data
entry, not by using the section name.

But '.build-id' is not a good choice for that section name, as it is 9
characters long, and hence truncated to 8 characters when
--disable-long-section-names is used (which is the default, when producing an
executable with no dwarf debug sections, e.g. using ld --strip-all --build-id)

This truncation then breaks 'objcopy --only-keep-debug', which does use the
section name, due to concerns that keeping an arbitrary section which contains
the debug directory is not sensible.

binutils/ChangeLog

2014-09-01  Jon TURNEY  <jon.turney@dronecode.org.uk>

* objcopy.c (is_nondebug_keep_contents_section): Change pe/coff
build-id section name from '.build-id' to '.buildid'.

ld/ChangeLog

2014-09-01  Jon TURNEY  <jon.turney@dronecode.org.uk>

* emultempl/pe.em (write_build_id, setup_build_id): Change pe/coff
build-id section name from '.build-id' to '.buildid'.
* emultempl/pep.em (write_build_id, setup_build_id): Ditto.

Signed-off-by: Jon TURNEY <jon.turney@dronecode.org.uk>
binutils/ChangeLog
binutils/objcopy.c
ld/ChangeLog
ld/emultempl/pe.em
ld/emultempl/pep.em