projects / platform / upstream / gst-plugins-good.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 6b50d14) | patch
rtpsession: Fix race when sending PLI, FIR and NACK packets
authorJohn Bassett <john.bassett@pexip.com>
Mon, 30 Apr 2018 08:54:19 +0000 (10:54 +0200)
committerNicolas Dufresne <nicolas@ndufresne.ca>
Fri, 5 Apr 2019 14:53:09 +0000 (14:53 +0000)
commit74a74bfc997543069527642e4805d9e45a3098df
tree8c727c2023868c3310232f75f82058f08489746etree | snapshot
parent6b50d142f34e55aeceb5416a14ab53ff1244299ccommit | diff
rtpsession: Fix race when sending PLI, FIR and NACK packets

Calling rtp_session_send_rtcp before marking the source as requiring a
pli/fir/nack meant the rtcp_thread could be scheduled and start running
before the source was updated. This meant the request would not be sent
early but instead was transmitted with the next regular RTCP packet.

Add test for nack generation.
gst/rtpmanager/rtpsession.c diff | blob | history
tests/check/elements/rtpsession.c diff | blob | history
Domain: Multimedia / Media Common;