x86/shstk: Remove useless clone error handling
authorRick Edgecombe <rick.p.edgecombe@intel.com>
Fri, 8 Sep 2023 20:36:54 +0000 (13:36 -0700)
committerDave Hansen <dave.hansen@linux.intel.com>
Tue, 19 Sep 2023 16:18:34 +0000 (09:18 -0700)
commit748c90c693363d05c6b2f3915edc7999a2f71837
tree759d5dcfb0efdf41fdc30052a48ec555270ceca5
parent331955600ddf55a2c6d92a00f95b0865f1c74fc3
x86/shstk: Remove useless clone error handling

When clone fails after the shadow stack is allocated, any allocated shadow
stack is cleaned up in exit_thread() in copy_process(). So the logic in
copy_thread() is unneeded, and also will not handle failures that happen
outside of copy_thread().

In addition, since there is a second attempt to unmap the same shadow
stack, there is a race where an newly mapped region could get unmapped.

So remove the logic in copy_thread() and rely on exit_thread() to handle
clone failure.

Fixes: b2926a36b97a ("x86/shstk: Handle thread shadow stack")
Signed-off-by: Rick Edgecombe <rick.p.edgecombe@intel.com>
Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Tested-by: H.J. Lu <hjl.tools@gmail.com>
Link: https://lore.kernel.org/all/20230908203655.543765-3-rick.p.edgecombe%40intel.com
arch/x86/kernel/process.c