xfrm: ipcomp: remove unnecessary get_cpu()
authorSabrina Dubroca <sd@queasysnail.net>
Fri, 16 Apr 2021 15:11:46 +0000 (17:11 +0200)
committerSteffen Klassert <steffen.klassert@secunet.com>
Mon, 19 Apr 2021 10:49:29 +0000 (12:49 +0200)
commit747b67088f8d34b3ec64d31447a1044be92dd348
tree67a3a9e9fd18a48a8270fc903a4f62a50b1f3be4
parent6218fe186109b93a2fa2343e13981e016e9961ab
xfrm: ipcomp: remove unnecessary get_cpu()

While testing ipcomp on a realtime kernel, Xiumei reported a "sleeping
in atomic" bug, caused by a memory allocation while preemption is
disabled (ipcomp_decompress -> alloc_page -> ... get_page_from_freelist).

As Sebastian noted [1], this get_cpu() isn't actually needed, since
ipcomp_decompress() is called in napi context anyway, so BH is already
disabled.

This patch replaces get_cpu + per_cpu_ptr with this_cpu_ptr, then
simplifies the error returns, since there isn't any common operation
left.

[1] https://lore.kernel.org/lkml/20190820082810.ixkmi56fp7u7eyn2@linutronix.de/

Cc: Juri Lelli <jlelli@redhat.com>
Reported-by: Xiumei Mu <xmu@redhat.com>
Suggested-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
net/xfrm/xfrm_ipcomp.c