[LoopPassManager + MemorySSA] Only enable use of MemorySSA for LPMs known to preserve it.
authorAlina Sbirlea <asbirlea@google.com>
Wed, 21 Aug 2019 17:00:57 +0000 (17:00 +0000)
committerAlina Sbirlea <asbirlea@google.com>
Wed, 21 Aug 2019 17:00:57 +0000 (17:00 +0000)
commit7425179fee9b4ed1ff6d366ee06487f05a1c0ab3
tree42f533a45605d2614eaef25446aec5cd03471ad1
parent954a012b4c75db77b99b259d9cc4edd8ab551c68
[LoopPassManager + MemorySSA] Only enable use of MemorySSA for LPMs known to preserve it.

Summary:
Add a flag to the FunctionToLoopAdaptor that allows enabling MemorySSA only for the loop pass managers that are known to preserve it.

If an LPM is known to have only loop transforms that *all* preserve MemorySSA, then use MemorySSA if `EnableMSSALoopDependency` is set.
If an LPM has loop passes that do not preserve MemorySSA, then the flag passed is `false`, regardless of the value of `EnableMSSALoopDependency`.

When using a custom loop pass pipeline via `passes=...`, use keyword `loop` vs `loop-mssa` to use MemorySSA in that LPM. If a loop that does not preserve MemorySSA is added while using the `loop-mssa` keyword, that's an error.

Add the new `loop-mssa` keyword to a few tests where a difference occurs when enabling MemorySSA.

Reviewers: chandlerc

Subscribers: mehdi_amini, Prazek, george.burgess.iv, sanjoy.google, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D66376

llvm-svn: 369548
24 files changed:
llvm/include/llvm/Analysis/LoopAnalysisManager.h
llvm/include/llvm/Transforms/Scalar/LoopPassManager.h
llvm/lib/Analysis/LoopAnalysisManager.cpp
llvm/lib/Passes/PassBuilder.cpp
llvm/test/Analysis/BasicAA/store-promote.ll
llvm/test/Transforms/LICM/argmemonly-call.ll
llvm/test/Transforms/LICM/atomics.ll
llvm/test/Transforms/LICM/guards.ll
llvm/test/Transforms/LICM/hoist-deref-load.ll
llvm/test/Transforms/LICM/hoist-phi.ll
llvm/test/Transforms/LICM/promote-order.ll
llvm/test/Transforms/LICM/read-only-calls.ll
llvm/test/Transforms/LICM/store-hoisting.ll
llvm/test/Transforms/LoopInstSimplify/basic.ll
llvm/test/Transforms/LoopRotate/basic.ll
llvm/test/Transforms/LoopRotate/pr35210.ll
llvm/test/Transforms/SimpleLoopUnswitch/basictest-profmd.ll
llvm/test/Transforms/SimpleLoopUnswitch/basictest.ll
llvm/test/Transforms/SimpleLoopUnswitch/guards.ll
llvm/test/Transforms/SimpleLoopUnswitch/msan.ll
llvm/test/Transforms/SimpleLoopUnswitch/trivial-unswitch-iteration.ll
llvm/test/Transforms/SimpleLoopUnswitch/trivial-unswitch-profmd.ll
llvm/test/Transforms/SimpleLoopUnswitch/trivial-unswitch.ll
llvm/test/Transforms/SimpleLoopUnswitch/update-scev.ll