[Reassociate] Skip analysis of dead code to avoid infinite loop.
authorBjorn Pettersson <bjorn.a.pettersson@ericsson.com>
Wed, 2 Nov 2016 08:55:19 +0000 (08:55 +0000)
committerBjorn Pettersson <bjorn.a.pettersson@ericsson.com>
Wed, 2 Nov 2016 08:55:19 +0000 (08:55 +0000)
commit7424c8ccd17b3c8e28d048cd13322d665154bb7a
tree08df843a6994c6d950e1cb50008ad7be2cad72ff
parent50e59f3b60d05006fc08ecb0a31eacc57c6373ed
[Reassociate] Skip analysis of dead code to avoid infinite loop.

Summary:
It was detected that the reassociate pass could enter an inifite
loop when analysing dead code. Simply skipping to analyse basic
blocks that are dead avoids such problems (and as a side effect
we avoid spending time on optimising dead code).

The solution is using the same Reverse Post Order ordering of the
basic blocks when doing the optimisations, as when building the
precalculated rank map. A nice side-effect of this solution is
that we now know that we only try to do optimisations for blocks
with ranked instructions.

Fixes https://llvm.org/bugs/show_bug.cgi?id=30818

Reviewers: llvm-commits, davide, eli.friedman, mehdi_amini

Subscribers: dberlin

Differential Revision: https://reviews.llvm.org/D26154

llvm-svn: 285793
llvm/include/llvm/Transforms/Scalar/Reassociate.h
llvm/lib/Transforms/Scalar/Reassociate.cpp
llvm/test/Transforms/Reassociate/deadcode.ll [new file with mode: 0644]