NFS: Fix an RCU lock leak in nfs4_refresh_delegation_stateid()
authorTrond Myklebust <trondmy@gmail.com>
Thu, 31 Oct 2019 22:40:33 +0000 (18:40 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 6 Nov 2019 12:06:22 +0000 (13:06 +0100)
commit74001646d47c900e2f817f684d92e4ce0f96e9eb
tree5ddc48cf3555c7edf3714b3ac33697612790b987
parentfd9a708c7bde2175357acf87ff3a4416b9807f59
NFS: Fix an RCU lock leak in nfs4_refresh_delegation_stateid()

commit 79cc55422ce99be5964bde208ba8557174720893 upstream.

A typo in nfs4_refresh_delegation_stateid() means we're leaking an
RCU lock, and always returning a value of 'false'. As the function
description states, we were always supposed to return 'true' if a
matching delegation was found.

Fixes: 12f275cdd163 ("NFSv4: Retry CLOSE and DELEGRETURN on NFS4ERR_OLD_STATEID.")
Cc: stable@vger.kernel.org # v4.15+
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/nfs/delegation.c