JIT: revise checking for computed preds (#81582)
authorAndy Ayers <andya@microsoft.com>
Fri, 3 Feb 2023 16:47:55 +0000 (08:47 -0800)
committerGitHub <noreply@github.com>
Fri, 3 Feb 2023 16:47:55 +0000 (08:47 -0800)
commit73f15736110a0236d0005e22ad7c770ee6e13ab9
tree0d85644279ba7791ca3a1d1bafb5eff58645b779
parenta6741d9c609cf402e319d67cc902cb574c15afa4
JIT: revise checking for computed preds (#81582)

Since pred lists now exist pervasively, change most methods that had
conditional pred list updates to assert preds exist and always update.

To make sure I got all uses, I renamed `fgComputePredsDone` to
`fgPredsComputed`.

Remove the ability to drop EH, as it doesn't update pred lists properly
and so has been broken for quite a while now.

Remove some of the logic for fixing up finally targets, since we now
always have pred lists around and so don't need the blanket invaliation.

Closes #80193.
15 files changed:
src/coreclr/jit/block.h
src/coreclr/jit/compiler.cpp
src/coreclr/jit/compiler.h
src/coreclr/jit/compiler.hpp
src/coreclr/jit/fgbasic.cpp
src/coreclr/jit/fgdiagnostic.cpp
src/coreclr/jit/fgehopt.cpp
src/coreclr/jit/fgflow.cpp
src/coreclr/jit/fgopt.cpp
src/coreclr/jit/fgprofile.cpp
src/coreclr/jit/flowgraph.cpp
src/coreclr/jit/indirectcalltransformer.cpp
src/coreclr/jit/jiteh.cpp
src/coreclr/jit/morph.cpp
src/coreclr/jit/ssabuilder.cpp