nfc: st21nfca: fix incorrect validating logic in EVT_TRANSACTION
authorMartin Faltesek <mfaltesek@google.com>
Tue, 7 Jun 2022 02:57:27 +0000 (21:57 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Jun 2022 16:36:26 +0000 (18:36 +0200)
commit73b28763050f0f5356f9096a57c88e9fb1805e32
tree0b4c7042a1f27b9ab5db89541357d8d8fc793a55
parentbafbc134f5b0948aa1ca015a0dff70b02c0152b7
nfc: st21nfca: fix incorrect validating logic in EVT_TRANSACTION

commit 77e5fe8f176a525523ae091d6fd0fbb8834c156d upstream.

The first validation check for EVT_TRANSACTION has two different checks
tied together with logical AND. One is a check for minimum packet length,
and the other is for a valid aid_tag. If either condition is true (fails),
then an error should be triggered.  The fix is to change && to ||.

Fixes: 26fc6c7f02cb ("NFC: st21nfca: Add HCI transaction event support")
Cc: stable@vger.kernel.org
Signed-off-by: Martin Faltesek <mfaltesek@google.com>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/nfc/st21nfca/se.c