binman: Correct operation of ObtainContents()
authorSimon Glass <sjg@chromium.org>
Fri, 6 Jul 2018 16:27:17 +0000 (10:27 -0600)
committerSimon Glass <sjg@chromium.org>
Mon, 9 Jul 2018 15:11:00 +0000 (09:11 -0600)
commit736bb0aec80891891f3f86004e1afa7976585918
tree0fc884fa334107d29956bb285eaff536c2c56beb
parentadc5701134f7041d7f767b672b66afb8b64ba5ce
binman: Correct operation of ObtainContents()

This method is supposed to return the contents of an entry. However at
present there is no check that it actually does. Also some implementations
do not return 'True' to indicate success, as required.

Add a check for things working as expected, and correct the
implementations.

This requires some additional test cases to cover things which were missed
originally. Add these at the same time.

Signed-off-by: Simon Glass <sjg@chromium.org>
tools/binman/bsection.py
tools/binman/etype/_testing.py
tools/binman/etype/section.py
tools/binman/etype/u_boot_spl_bss_pad.py
tools/binman/etype/u_boot_ucode.py
tools/binman/ftest.py
tools/binman/test/57_unknown_contents.dts [new file with mode: 0644]
tools/binman/test/58_x86_ucode_spl_needs_retry.dts [new file with mode: 0644]