PCI: aardvark: Fix reading PCI_EXP_RTSTA_PME bit on emulated bridge
authorPali Rohár <pali@kernel.org>
Mon, 10 Jan 2022 01:50:09 +0000 (02:50 +0100)
committerLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Tue, 8 Feb 2022 10:44:04 +0000 (10:44 +0000)
commit735f5ae49e1b44742cc63ca9b5c1ffde3e94ba91
treeb0415bf2b09564f182c62e30e5f8d5c3632d0f94
parent3ebfefa396ebee21061fd5fa36073368ed2cd467
PCI: aardvark: Fix reading PCI_EXP_RTSTA_PME bit on emulated bridge

The emulated bridge returns incorrect value for PCI_EXP_RTSTA register
during readout in advk_pci_bridge_emul_pcie_conf_read() function: the
correct bit is BIT(16), but we are setting BIT(23), because the code
does
  *value = (isr0 & PCIE_MSG_PM_PME_MASK) << 16
where
  PCIE_MSG_PM_PME_MASK
is
  BIT(7).

The code should probably have been something like
  *value = (!!(isr0 & PCIE_MSG_PM_PME_MASK)) << 16,
but we are better of using an if() and using the proper macro for this
bit.

Link: https://lore.kernel.org/r/20220110015018.26359-15-kabel@kernel.org
Fixes: 8a3ebd8de328 ("PCI: aardvark: Implement emulated root PCI bridge config space")
Signed-off-by: Pali Rohár <pali@kernel.org>
Signed-off-by: Marek Behún <kabel@kernel.org>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
drivers/pci/controller/pci-aardvark.c