block/rnbd: fix a null pointer dereference on dev->blk_symlink_name
authorColin Ian King <colin.king@canonical.com>
Mon, 7 Dec 2020 14:54:46 +0000 (14:54 +0000)
committerJens Axboe <axboe@kernel.dk>
Mon, 7 Dec 2020 15:00:32 +0000 (08:00 -0700)
commit733c15bd3a944b8eeaacdddf061759b6a83dd3f4
treeeb2e3e2f2ab8a6c2eefcebd373d2dba1b172336f
parent64e8a6ece1a5b1fa21316918053d068baeac84af
block/rnbd: fix a null pointer dereference on dev->blk_symlink_name

Currently in the case where dev->blk_symlink_name fails to be allocates
the error return path attempts to set an end-of-string character to
the unallocated dev->blk_symlink_name causing a null pointer dereference
error. Fix this by returning with an explicity ENOMEM error (which also
is missing in the original code as was not initialized).

Fixes: 1eb54f8f5dd8 ("block/rnbd: client: sysfs interface functions")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Addresses-Coverity: ("Dereference after null check")
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/rnbd/rnbd-clt-sysfs.c