Bluetooth: hci_qca: Use del_timer_sync() before freeing
authorSteven Rostedt <rostedt@goodmis.org>
Tue, 5 Apr 2022 14:02:00 +0000 (10:02 -0400)
committerMarcel Holtmann <marcel@holtmann.org>
Fri, 13 May 2022 11:05:48 +0000 (13:05 +0200)
commit72ef98445aca568a81c2da050532500a8345ad3a
tree38d3e33c63bf313ff0ac7edf2bb70945ce26aac6
parentbf7380e224f98a29ff6290beb2ea026f0a044a8c
Bluetooth: hci_qca: Use del_timer_sync() before freeing

While looking at a crash report on a timer list being corrupted, which
usually happens when a timer is freed while still active. This is
commonly triggered by code calling del_timer() instead of
del_timer_sync() just before freeing.

One possible culprit is the hci_qca driver, which does exactly that.

Eric mentioned that wake_retrans_timer could be rearmed via the work
queue, so also move the destruction of the work queue before
del_timer_sync().

Cc: Eric Dumazet <eric.dumazet@gmail.com>
Cc: stable@vger.kernel.org
Fixes: 0ff252c1976da ("Bluetooth: hciuart: Add support QCA chipset for UART")
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
drivers/bluetooth/hci_qca.c