x86: crash_dump: Fix non-pae kdump kernel memory accesses
authorJiri Slaby <jirislaby@gmail.com>
Mon, 26 Oct 2009 10:11:43 +0000 (11:11 +0100)
committerIngo Molnar <mingo@elte.hu>
Mon, 26 Oct 2009 11:38:59 +0000 (12:38 +0100)
commit72ed7de74e8f0fad0d8e567ae1f987b740accb3f
treedd8e7dbd4b6305bcca35fc2cfe29479918e034d2
parentae1b22f6e46c03cede7cea234d0bf2253b4261cf
x86: crash_dump: Fix non-pae kdump kernel memory accesses

Non-PAE 32-bit dump kernels may wrap an address around 4G and
poke unwanted space. ptes there are 32-bit long, and since
pfn << PAGE_SIZE may exceed this limit, high pfn bits are
cropped and wrong address mapped by kmap_atomic_pfn in
copy_oldmem_page.

Don't allow this behavior in non-PAE kdump kernels by checking
pfns passed into copy_oldmem_page. In the case of failure,
userspace process gets EFAULT.

[v2]
- fix comments
- move ifdefs inside the function

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Cc: Vivek Goyal <vgoyal@redhat.com>
Cc: Eric W. Biederman <ebiederm@xmission.com>
Cc: Simon Horman <horms@verge.net.au>
Cc: Paul Mundt <lethal@linux-sh.org>
LKML-Reference: <1256551903-30567-1-git-send-email-jirislaby@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
arch/x86/kernel/crash_dump_32.c