platform/x86: think-lmi: Prevent underflow in index_store()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 17 Dec 2021 07:12:09 +0000 (10:12 +0300)
committerHans de Goede <hdegoede@redhat.com>
Tue, 21 Dec 2021 17:57:14 +0000 (18:57 +0100)
commit72e4d07d9499d979a3fc38c77f4120707c709ea5
treed50062f137ab7380737dbc3c0cf59ee34b9c135d
parent855045873b54b9f8dd71a0468db9ff52aa27444f
platform/x86: think-lmi: Prevent underflow in index_store()

There needs to be a check to prevent negative offsets for
setting->index.  I have reviewed this code and I think that the
"if (block->instance_count <= instance)" check in __query_block() will
prevent this from resulting in an out of bounds access.  But it's
still worth fixing.

Fixes: 640a5fa50a42 ("platform/x86: think-lmi: Opcode support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20211217071209.GF26548@kili
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/think-lmi.c