rtc: cros-ec: return -ETIME when refused to set alarms in the past
authorJeffy Chen <jeffy.chen@rock-chips.com>
Tue, 27 Feb 2018 02:50:03 +0000 (10:50 +0800)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Sat, 17 Mar 2018 13:20:53 +0000 (14:20 +0100)
commit72dd71f0dae47183efdf92279927ff26f0ed9f3f
treedc1dcc6102d2b0eed193a1c069403d95888dda17
parent83220bf38b77a830f8e62ab1a0d0408304f9b966
rtc: cros-ec: return -ETIME when refused to set alarms in the past

Since accessing a Chrome OS EC based rtc is a slow operation, there is a
race window where if the alarm is set for the next second and the second
ticks over right before calculating the alarm offset.

In this case the current driver is setting a 0-second alarm, which would
be considered as disabling alarms by the EC(EC_RTC_ALARM_CLEAR).

This breaks, e.g., hwclock which relies on RTC_UIE_ON ->
rtc_update_irq_enable(), which sets a 1-second alarm and expects it to
fire an interrupt.

So return -ETIME when the alarm is in the past, follow __rtc_set_alarm().

Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
Reviewed-by: Brian Norris <briannorris@chromium.org>
Tested-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-cros-ec.c