mac80211: Fix kernel panic due to use of txq after free
authorBhagavathi Perumal S <bperumal@codeaurora.org>
Tue, 16 Apr 2019 07:24:40 +0000 (12:54 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 25 May 2019 16:26:55 +0000 (18:26 +0200)
commit72d00b6e9a74534fb5e872eea6c46c77ec8e3746
tree52d81c54e6ee5c9519588036061fc1c63bf62ead
parent5b28db54bf2497a4b77f61d96b8cff553387a798
mac80211: Fix kernel panic due to use of txq after free

[ Upstream commit f1267cf3c01b12e0f843fb6a7450a7f0b2efab8a ]

The txq of vif is added to active_txqs list for ATF TXQ scheduling
in the function ieee80211_queue_skb(), but it was not properly removed
before freeing the txq object. It was causing use after free of the txq
objects from the active_txqs list, result was kernel panic
due to invalid memory access.

Fix kernel invalid memory access by properly removing txq object
from active_txqs list before free the object.

Signed-off-by: Bhagavathi Perumal S <bperumal@codeaurora.org>
Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/mac80211/iface.c