radv: allow inline push constants in more situations
authorRhys Perry <pendingchaos02@gmail.com>
Fri, 17 Dec 2021 19:09:46 +0000 (19:09 +0000)
committerMarge Bot <emma+marge@anholt.net>
Tue, 12 Apr 2022 11:44:30 +0000 (11:44 +0000)
commit72cf6cca914d95499a40c5257a5e2cdd26b89afa
treef44f8cb31bd3aa85ecc54d35dbc8855bd1e8f0de
parent9c7e750ffe373f5fe91269e112e8a2fe2cc3b8f2
radv: allow inline push constants in more situations

We don't need to disable this path if there are indirect or 8/16/64-bit
push constant loads. We can just use the default path for them.

fossil-db (Sienna Cichlid):
Totals from 21 (0.02% of 134621) affected shaders:
CodeSize: 2028 -> 1884 (-7.10%)
Instrs: 366 -> 363 (-0.82%); split: -2.46%, +1.64%
Latency: 6630 -> 6579 (-0.77%)
InvThroughput: 26520 -> 26316 (-0.77%)
Copies: 84 -> 102 (+21.43%)
PreSGPRs: 141 -> 222 (+57.45%)

Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12145>
src/amd/vulkan/radv_shader_args.c