cifs: refcount only the selected iface during interface update
authorShyam Prasad N <sprasad@microsoft.com>
Tue, 27 Dec 2022 11:29:28 +0000 (11:29 +0000)
committerSteve French <stfrench@microsoft.com>
Thu, 5 Jan 2023 05:17:39 +0000 (23:17 -0600)
commit7246210ecdd0cda97fa3e3bb15c32c6c2d9a23b5
treecbd7c8fd87877eda7ac54dc368aaf78b9db36369
parent39a154fc2d172a3a5865e5a9fa2a2983eb7a99ac
cifs: refcount only the selected iface during interface update

When the server interface for a channel is not active anymore,
we have the logic to select an alternative interface. However
this was not breaking out of the loop as soon as a new alternative
was found. As a result, some interfaces may get refcounted unintentionally.

There was also a bug in checking if we found an alternate iface.
Fixed that too.

Fixes: b54034a73baf ("cifs: during reconnect, update interface if necessary")
Cc: stable@vger.kernel.org # 5.19+
Signed-off-by: Shyam Prasad N <sprasad@microsoft.com>
Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/cifs/sess.c