IPoIB: Drop priv->lock before calling ipoib_send()
authorRoland Dreier <rolandd@cisco.com>
Sun, 6 Sep 2009 03:23:40 +0000 (20:23 -0700)
committerRoland Dreier <rolandd@cisco.com>
Sun, 6 Sep 2009 03:23:40 +0000 (20:23 -0700)
commit721d67cdca5b7642b380ca0584de8dceecf6102f
treeff54ae434cca6f6d860504094daa84df645ad4db
parentcd0bcf4cb963a147baf0b79d94c25ba86220f708
IPoIB: Drop priv->lock before calling ipoib_send()

IPoIB currently must use irqsave locking for priv->lock, since it is
taken from interrupt context in one path.  However, ipoib_send() does
skb_orphan(), and the network stack locking is not IRQ-safe.
Therefore we need to make sure we don't hold priv->lock when calling
ipoib_send() to avoid lockdep warnings (the code was almost certainly
safe in practice, since the only code path that takes priv->lock from
interrupt context would never call into the network stack).

Addresses: http://bugzilla.kernel.org/show_bug.cgi?id=13757
Reported-by: Bart Van Assche <bart.vanassche@gmail.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
drivers/infiniband/ulp/ipoib/ipoib_main.c
drivers/infiniband/ulp/ipoib/ipoib_multicast.c