[CherryPick] flex-grow should be 1 when flex:auto
authortony@chromium.org <tony@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 24 Sep 2012 21:35:13 +0000 (21:35 +0000)
committerGerrit Code Review <gerrit2@kim11>
Wed, 22 May 2013 00:43:24 +0000 (09:43 +0900)
commit72040b614bec39ed6b83faaffc9b8f8f32859f13
treeda6f39fc71656a3b72205f8c3c5dae2dd682a8ff
parent03536cc5a7e8f02bc56d48b15c71896d08a9468d
[CherryPick] flex-grow should be 1 when flex:auto

[Title] [CherryPick] flex-grow should be 1 when flex:auto
[Issue] TWEB-1141
[Problem] 'flex:auto' is equivalent to 'flex: 1 1 auto' but got 'fiex: 0 1 auto'
[Cause] The flex-grow value was set to 0 when 'flex:auto'. It should be 1.
[Solution] Cherry-pick the opensource patch.
[Cherry-Picker] KyungTae Kim <ktf.kim@samsung.com>

flex-grow should be 1 when omitted from flex shorthand
https://bugs.webkit.org/show_bug.cgi?id=97480

Reviewed by Ojan Vafai.

Source/WebCore:

We were using 0, based on an outdated version of the spec.

Tests: css3/flexbox/flex-property-parsing.html
       css3/flexbox/flex-algorithm.html: New test case.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseFlex):

LayoutTests:

Update tests due to default CSS value changes.

* css3/flexbox/flex-algorithm-expected.txt:
* css3/flexbox/flex-algorithm.html: Add test case using -webkit-flex: auto.
* css3/flexbox/flex-property-parsing-expected.txt:
* css3/flexbox/flex-property-parsing.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Conflicts:

LayoutTests/ChangeLog
Source/WebCore/ChangeLog

Change-Id: I9085db2b10a723c8a1efd3050f2087ab7e8751cd
LayoutTests/ChangeLog
LayoutTests/css3/flexbox/flex-algorithm-expected.txt
LayoutTests/css3/flexbox/flex-algorithm.html
LayoutTests/css3/flexbox/flex-property-parsing-expected.txt
LayoutTests/css3/flexbox/flex-property-parsing.html
Source/WebCore/ChangeLog
Source/WebCore/css/CSSParser.cpp