block, bfq: refactor the counting of 'num_groups_with_pending_reqs'
authorYu Kuai <yukuai3@huawei.com>
Fri, 16 Sep 2022 07:19:39 +0000 (15:19 +0800)
committerJens Axboe <axboe@kernel.dk>
Tue, 1 Nov 2022 13:09:44 +0000 (07:09 -0600)
commit71f8ca77cb8764d46f656b725999e8b8b1aec215
tree0382b29e3b2b8121239f00ca1b89d3a31a85127e
parent60a6e10c537a7459dd53882186bd16fff257fb03
block, bfq: refactor the counting of 'num_groups_with_pending_reqs'

Currently, bfq can't handle sync io concurrently as long as they
are not issued from root group. This is because
'bfqd->num_groups_with_pending_reqs > 0' is always true in
bfq_asymmetric_scenario().

The way that bfqg is counted into 'num_groups_with_pending_reqs':

Before this patch:
 1) root group will never be counted.
 2) Count if bfqg or it's child bfqgs have pending requests.
 3) Don't count if bfqg and it's child bfqgs complete all the requests.

After this patch:
 1) root group is counted.
 2) Count if bfqg have pending requests.
 3) Don't count if bfqg complete all the requests.

With this change, the occasion that only one group is activated can be
detected, and next patch will support concurrent sync io in the
occasion.

Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Acked-by: Paolo Valente <paolo.valente@linaro.org>
Link: https://lore.kernel.org/r/20220916071942.214222-4-yukuai1@huaweicloud.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/bfq-iosched.c
block/bfq-iosched.h
block/bfq-wf2q.c