io-wq: Remove duplicate code in io_workqueue_create()
authorBixuan Cui <cuibixuan@huawei.com>
Sat, 11 Sep 2021 08:58:47 +0000 (16:58 +0800)
committerJens Axboe <axboe@kernel.dk>
Tue, 19 Oct 2021 11:49:52 +0000 (05:49 -0600)
commit71e1cef2d794338cc7b979d4c6144e1dc12718b5
treeab3540da285ea69d553813fcf8a183f5530dde89
parenta87acfde949140946456859eafa5f15175d0f960
io-wq: Remove duplicate code in io_workqueue_create()

While task_work_add() in io_workqueue_create() is true,
then duplicate code is executed:

  -> clear_bit_unlock(0, &worker->create_state);
  -> io_worker_release(worker);
  -> atomic_dec(&acct->nr_running);
  -> io_worker_ref_put(wq);
  -> return false;

  -> clear_bit_unlock(0, &worker->create_state); // back to io_workqueue_create()
  -> io_worker_release(worker);
  -> kfree(worker);

The io_worker_release() and clear_bit_unlock() are executed twice.

Fixes: 3146cba99aa2 ("io-wq: make worker creation resilient against signals")
Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>
Link: https://lore.kernel.org/r/20210911085847.34849-1-cuibixuan@huawei.com
Reviwed-by: Hao Xu <haoxu@linux.alibaba.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
fs/io-wq.c