staging: comedi: dt282x: dt282x_ai_insn_read() always fails
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 20 Aug 2013 08:57:35 +0000 (11:57 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 26 Sep 2013 23:52:46 +0000 (16:52 -0700)
commit71d5f63763f01e5577c465d6752b7060ba105fa6
treea73ab3e32383f32ea18ff7e573e985a04c383c9c
parent186ad2276339b0fc63f06146627b6d15c5058c4f
staging: comedi: dt282x: dt282x_ai_insn_read() always fails

commit 2c4283ca7cdcc6605859c836fc536fcd83a4525f upstream.

In dt282x_ai_insn_read() we call this macro like:
wait_for(!mux_busy(), comedi_error(dev, "timeout\n"); return -ETIME;);
Because the if statement doesn't have curly braces it means we always
return -ETIME and the function never succeeds.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/dt282x.c