platform/chrome: cros_ec_rpmsg: Fix race with host command when probe failed
authorPi-Hsun Shih <pihsun@chromium.org>
Wed, 4 Sep 2019 06:26:13 +0000 (14:26 +0800)
committerEnric Balletbo i Serra <enric.balletbo@collabora.com>
Thu, 12 Sep 2019 14:20:50 +0000 (16:20 +0200)
commit71cddb7097e2b0feb855d7fd7d59afd12cbee4bb
tree8a3830ff34eceb78811ab73355c38c5c816b2539
parent0144c00ed86bc34b8318268fb63f10ecccf0445c
platform/chrome: cros_ec_rpmsg: Fix race with host command when probe failed

Since the rpmsg_endpoint is created before probe is called, it's
possible that a host event is received during cros_ec_register, and
there would be some pending work in the host_event_work workqueue while
cros_ec_register is called.

If cros_ec_register fails, when the leftover work in host_event_work
run, the ec_dev from the drvdata of the rpdev could be already set to
NULL, causing kernel crash when trying to run cros_ec_get_next_event.

Fix this by creating the rpmsg_endpoint by ourself, and when
cros_ec_register fails (or on remove), destroy the endpoint first (to
make sure there's no more new calls to cros_ec_rpmsg_callback), and then
cancel all works in the host_event_work workqueue.

Cc: stable@vger.kernel.org
Fixes: 2de89fd98958 ("platform/chrome: cros_ec: Add EC host command support using rpmsg")
Signed-off-by: Pi-Hsun Shih <pihsun@chromium.org>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
drivers/platform/chrome/cros_ec_rpmsg.c