[VFS] Combine VFSFromYamlDirIterImpl and OverlayFSDirIterImpl into a single implement...
authorNathan Hawes <nhawes@apple.com>
Sat, 16 Jan 2021 01:44:14 +0000 (11:44 +1000)
committerNathan Hawes <nhawes@apple.com>
Sat, 30 Jan 2021 01:10:10 +0000 (11:10 +1000)
commit719f778441750dcadcf7c7c411d1cfb39029d59a
tree8b42f7b1c8fb40d3f78c965378b9976e522e476a
parent0af25275364e27d9766eb0912a5dd9731d62936b
[VFS] Combine VFSFromYamlDirIterImpl and OverlayFSDirIterImpl into a single implementation (NFC)

As a fixme notes, both of these directory iterator implementations are
conceptually similar and duplicate the functionality of returning and uniquing
entries across two or more directories. This patch combines them into a single
class 'CombiningDirIterImpl'.

This also drops the 'Redirecting' prefix from RedirectingDirEntry and
RedirectingFileEntry to save horizontal space. There's no loss of clarity as
they already have to be prefixed with 'RedirectingFileSystem::' whenever
they're referenced anyway.

rdar://problem/72485443
Differential Revision: https://reviews.llvm.org/D94857
lldb/source/Host/common/FileSystem.cpp
llvm/include/llvm/Support/VirtualFileSystem.h
llvm/lib/Support/VirtualFileSystem.cpp