inputselector: Deactivate and remove pad without the inputselector lock
authorSebastian Dröge <slomo@circular-chaos.org>
Fri, 12 Jul 2013 08:08:26 +0000 (10:08 +0200)
committerSebastian Dröge <slomo@circular-chaos.org>
Fri, 12 Jul 2013 08:08:26 +0000 (10:08 +0200)
commit717ad2091209bf3b736cfd9784ca1e710a5020a6
tree51138bb8cc7058d22725d5ceaa57e5947217029c
parentf8fdb61b02cbcfc6f6bbc136ada329db128dab3f
inputselector: Deactivate and remove pad without the inputselector lock

Otherwise we might get deadlocks caused by lock order inversion:
During the chain function the stream lock is first locked and then the
inputselector lock. During pad release we first locked the inputselector
lock and then deactivating the pad would lock the stream lock.

There's no reason why the inputselector lock should be required while
deactivating and removing the pad, it's only needed before.

https://bugzilla.gnome.org/show_bug.cgi?id=704002
plugins/elements/gstinputselector.c