dfu: mmc: raw data write fix
authorMateusz Zalega <m.zalega@samsung.com>
Mon, 28 Apr 2014 19:13:24 +0000 (21:13 +0200)
committerLukasz Majewski <l.majewski@samsung.com>
Mon, 5 May 2014 06:00:28 +0000 (08:00 +0200)
commit711b931f90e44ff1248cd73c15f64485470d86ff
treeba210677e3fa0c50a74a357a997931530a4e12db
parent75504e9592745021006cb8905b5ff5a51d9d1cb3
dfu: mmc: raw data write fix

When user attempted to perform a raw write using DFU (vide
dfu_fill_entity_mmc) with MMC interface not initialized before,
get_mmc_blk_size() reported invalid (zero) block size - it wasn't
possible to write ie. a new u-boot image.

This commit fixes that by initializing MMC device before use in
dfu_fill_entity_mmc().

While fixing initialization sequence, I had to change about half of
dfu_fill_entity_mmc's body, so I refactored it on the way to make it,
IMHO, considerably more comprehensible.

Being left as dead code, get_mmc_blk_size() was removed.

Tested on Samsung Goni.

Signed-off-by: Mateusz Zalega <m.zalega@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Acked-by: Lukasz Majewski <l.majewski@samsung.com>
Acked-by: Tom Rini <trini@ti.com>
Cc: Minkyu Kang <mk7.kang@samsung.com>
drivers/dfu/dfu_mmc.c
include/dfu.h